Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a new function Stop-VSTeamBuild #317

Merged
merged 6 commits into from
May 21, 2020
Merged

Adds a new function Stop-VSTeamBuild #317

merged 6 commits into from
May 21, 2020

Conversation

brittandeyoung
Copy link
Contributor

@brittandeyoung brittandeyoung commented May 20, 2020 •
edited
Loading

PR Summary

PR Checklist

@SebastianSchuetze SebastianSchuetze added the enhancement Improvements that do not include new features label May 20, 2020
@SebastianSchuetze SebastianSchuetze linked an issue May 20, 2020 that may be closed by this pull request
Feature Request: Cancel existing build #206
Closed
@SebastianSchuetze
Copy link
Collaborator

Hi @brittandeyoung
looks great already. One small thing is missing. Could you create a help document like the following?https://github.com/DarqueWarrior/vsteam/blob/master/.docs/Add-VSTeamBuild.md

A cmdlet should have help page which links the synopsis. Thank you!

@SebastianSchuetze SebastianSchuetze self-requested a review May 20, 2020 14:17
@SebastianSchuetze SebastianSchuetze changed the title Topic/enhancement issue206 Adds a new function Stop-VSTeamBuild May 20, 2020
@brittandeyoung
Copy link
Contributor Author

Hi @brittandeyoung
looks great already. One small thing is missing. Could you create a help document like the following?https://github.com/DarqueWarrior/vsteam/blob/master/.docs/Add-VSTeamBuild.md

A cmdlet should have help page which links the synopsis. Thank you!

I have added the requested help page. Please let me know if there is anything else I am missing.

SebastianSchuetze
SebastianSchuetze approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I will merge soon. Thanks for contributing.

@SebastianSchuetze SebastianSchuetze merged commit 046c7f5 into MethodsAndPractices:master May 21, 2020
@SebastianSchuetze
Copy link
Collaborator

I merged the PR and adjusted a few lines of code for optimization and added a unit test for testing the pipeline feature for build IDs.

Thanks for the good and quick contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianSchuetze SebastianSchuetze SebastianSchuetze approved these changes

Assignees
No one assigned
Labels
enhancement Improvements that do not include new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Cancel existing build
2 participants
@brittandeyoung @SebastianSchuetze