Remove deadlock when endpoint creation failed #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay I will try and review today. |
|
Please add unit tests to cover your new code. |
Returning a value implies we expect it to fail. Failing to create is an exception to what we expect to happen.
|
You're right, it's better. Is it consistant with the other parts of the module? |
|
The only other place where I track a process is creating a project. I want to complete the PR then we can see if we want to add that there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If and endpoint creation failed, the status of the endpoint is kept at $false and the _trackProgress method never ends.
If the status is $false, I add a check on the operational status to verify if the creation is still in progress. If there is a failure I write the failure message on the error output