-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get-VSTeamGroup / Get-VSTeamDescriptor #140
Conversation
Also, the other Unit Tests seem to work on my system, and I can't figure out what I'm doing wrong. I'm sure you can take a quick look and spot it immediately.. thanks! 👍 |
I will review today. |
All the tests are passing now. Take a look at the changes I made to make sure they are in line with what you were going for. I would like to get all the commented out code either removed for working before we merge to master. |
Thanks! Yes, the changes make sense, and I understand it now, perfect. |
Found out how to use SubjectTypes, pushed changes with Docs and new Unit Tests. |
@DarqueWarrior |
Sorry for the delay I am on a work trip. I am looking into now. |
PR Summary
Add Get-VSTeamGroup / Get-VSTeamDescriptor
I'm looking to get this PR through before I add more commands related to this (e.g. New-VSTeamGroup ;) , Add-VSTeamGroupMember, Set-VSTeamAccessControlEntry, things like that), but I'd like to see if my contribution is up to the standards first.
Also, I seem to have (at least?) 1 failing Test, which I somehow cannot figure out... A little hint would be appreciated 🥇
Executing script C:\MIZE\DEV\GitHub\vsteam\unit\test\groups.Tests.ps1
Describing Groups VSTS Context Get-VSTeamGroup by project [-] Should return groups 122ms Expected Invoke-RestMethod in module VSTeam to be called 1 times exactly but was called 0 times 34: Assert-MockCalled Invoke-RestMethod -Exactly 1 -ParameterFilter { at <ScriptBlock>, C:\MIZE\DEV\GitHub\vsteam\unit\test\groups.Tests.ps1: line 34
The Url looks exactly the same when I execute with -Verbose in a normal PS window... :(
Thanks!
PR Checklist