-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not change the strict mode setting for the user's PowerShell session #296
Comments
Thanks for all the great feedback. Please keep it coming. |
@DarqueWarrior will you do it in your review PR or should I make a PR for this issue and #297 BTW. accidentally closed the issue. Too fat fingers on mobile... 😬 |
I will look at both of these today. |
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Strict mode is a user choice. Code should be developed and tested so that it does not fail if the user selects the strictest mode, but changing strict mode on loading will break other code which assumed the mode was relaxed.
There are 3 places where strict mode is turned on.
Private\callMembershipAPI.ps1:12
Private\common.ps1:1
Public\Test-VSTeamMembership.ps1:11:
These appear to be errors, because if the intent were to run the module in strict mode I would expect it to be set once for the whole module
(I have changed this in my branch :-) )
The text was updated successfully, but these errors were encountered: