-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results for Simple.Data #702
Comments
Do you have a link for your tests? There are also errors in the output first thing, so I'm not sure what's happening there. |
What would be the best way to share results? I have just cloned repository, made some minimal changes, started test, and copied results from console.
global.json
Dapper.Tests/Tests.cs
System info: |
Error that is shown in console is not something important. It seems that it cannot load msvcr100.dll in LoadNativeAssembly method:
I'm not sure is Simple.Data correctly used. Simple.Data.FindById() returns SimpleQuery instance. I'm not familiar with Simple.Data, but I'm not sure does this method actually do something or just returns something like IQueryable.
Results with added FirstOrDefault() in Simple.Data are:
Could you re-run the test in your environment with and without this change, and could someone who is more familiar with Simple.Data review that code? |
Any update on this issue? I believe that test is not correct, so could anyone confirm this? I can send PR to change it, but it would be nice to know is this actually an error. |
@jovanpop-msft Sorry, I've been crazy on time latest - yes I agree that Would you like to submit a PR to credit on finding/fixing here? We need to refactor all those tests into Benchmark.net (#666), but this definitely needs fixing regardless. |
Thanks @NickCraver, PR is submitted here: #723 |
Closing this out - fixed in #723! |
I have executed test on Windows 10 / SQL Server 2016 Express SP1 (local named instance - I have changed connection string to .\SQLEXPRESS), and I got very good results for Simple.Data that are not reported in benchmark. It seems that it is even faster than hand coded DAO, which is very surprising (but I don't see any error in code). Could you double-check results for Simple.Data and publish result?
My results are below:
The text was updated successfully, but these errors were encountered: