Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapper actually does some connection management #634

Closed
adamkirkton opened this issue Oct 26, 2016 · 1 comment
Closed

Dapper actually does some connection management #634

adamkirkton opened this issue Oct 26, 2016 · 1 comment

Comments

@adamkirkton
Copy link

Under the Limitations and Caveats section in the README.md it says:

Dapper does not manage your connection's lifecycle, it assumes the connection it gets is open AND has no existing datareaders enumerating (unless MARS is enabled)

Which isn't completely true anymore. It's a small thing but it misled me as a new user of the library and can introduce some annoying and unnecessary code to open and close the connection all the time.

@mgravell
Copy link
Member

mgravell commented Nov 4, 2016

True; fixed - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants