Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters with special characters (æøå) #601

Closed
dennismi opened this issue Sep 8, 2016 · 2 comments
Closed

parameters with special characters (æøå) #601

dennismi opened this issue Sep 8, 2016 · 2 comments

Comments

@dennismi
Copy link

dennismi commented Sep 8, 2016

the "smellsLikeOleDb" regex in version 1.42 (i know it is an old version - but cannot upgrade right now) does not take into account any special characters (æøå) in parameter names.

Well atleast as far as i can see that is the problem. I may have been fixed in later versions but as of now, we cannot upgrade right now - we have tried, and we need to make a focused effort to do it.

Am i wrong in my findings?

regards
Dennis

@mgravell
Copy link
Member

mgravell commented Sep 8, 2016

You're not wrong; I don't know what DB/provider you're using, but for SQL Server, it is defined as:

A letter as defined by the Unicode Standard 3.2. The Unicode definition of letters includes Latin characters from a through z, from A through Z, and also letter characters from other languages.

That means I can probably switch to \p{L} in the regex; will have a look

@mgravell
Copy link
Member

mgravell commented Sep 8, 2016

It isn't just smellsLikeOleDb impacted - other re too; but fix looks simple - pushing in a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants