Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarification on "Limitations and caveats" #451

Closed
justinmk opened this issue Feb 4, 2016 · 1 comment
Closed

clarification on "Limitations and caveats" #451

justinmk opened this issue Feb 4, 2016 · 1 comment
Labels
documentation

Comments

@justinmk
Copy link

justinmk commented Feb 4, 2016

Is the Limitations and caveats section of the readme outdated?

The current implementation caches this information in a ConcurrentDictionary object. The objects it stores are never flushed.

8ed5f61 added automatic GC.

If you are generating SQL strings on the fly without using parameters it is possible you will hit memory issues.

Does 8747316 have implications for that statement?
@NickCraver
Copy link
Member

Yes, 8747316 added back unbounded implications, but since we don't track a hit count there cleanup isn't so easy. @mgravell think this is an issue?

@NickCraver NickCraver mentioned this issue Jan 28, 2017
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickCraver @justinmk