Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of Bounds Memory Access Using parity_wasm::deserialize_buffer #155

Closed
JakeOShannessy opened this issue Jun 5, 2019 · 2 comments
Closed

Comments

@JakeOShannessy
Copy link
Contributor

The validation library is now linked to the kernel, but throws a memory access error (MemoryAccessOutOfBounds) when using parity_wasm::deserialize_buffer.

This is due to insufficient memory allocation in wasm. Perhaps this is something about the way that parity-wasm requests/allocates memory that doesn't fit with the memory allocation in the pwasm toolchain. I was able to hack around this by manually increasing the number of memory pages in the kernel wasm file manually (from 2 to 5).

For the purposes of testing it's probably worth just bumping the memory up until we get a better handle on what the issue is.

@JakeOShannessy
Copy link
Contributor Author

In order for this hack to work LTO needs to be turned off. This has been done in the validation branch.

@JakeOShannessy
Copy link
Contributor Author

This has been fixed via a new parser in #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant