Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in extract/inject format constants #5

Open
williambailey opened this issue Feb 22, 2018 · 2 comments
Open

Mismatch in extract/inject format constants #5

williambailey opened this issue Feb 22, 2018 · 2 comments

Comments

@williambailey
Copy link

I'm having issues using this library as a transport for the opentracing package via opentracing.initGlobalTracer(tracer); due to a mismatch in the values of the transport constants.

The result is Error: extract called with unsupported format when trying to use the tracer to extract or inject.

The opentracing packages has export const FORMAT_HTTP_HEADERS = 'http_headers';

This packages has Tracing.FORMAT_HTTP_HEADERS = "FORMAT_HTTP_HEADERS";

@DanielMSchmidt
Copy link
Owner

Thank you for filing the issue 👍 It appears that you made all the research necessary to fix this issue, it would be great if you could file a PR for this. I would totally love a little unit test catching this in the future if you have the time. Thank you for your interest on this project 👍

@DanielMSchmidt
Copy link
Owner

We even have opentracing as peer dependency, I wonder why there is no test to notice this 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants