Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master to develop #5

Merged
merged 108 commits into from
Aug 4, 2019
Merged

master to develop #5

merged 108 commits into from
Aug 4, 2019

Conversation

DanaPeled
Copy link
Owner

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

nschonni and others added 30 commits July 23, 2019 11:53
- Add "body" to response
- createGroupRequest -> createManagementGroupRequest
* Updated QnAMaker  Runtime API headers descriptions

* Update swagger title

* removed content-type header

* Common tag and title for Runtime
Undo Authorization header change

* Update title

* update readme

* update readme
* update package '@azure/rest-api-specs-scripts' 0.4.0

* remove '@azure/rest-api-specs-scripts' related job in preproduction pipeline.

* fix
* Added Keyvault and MSI parameters to create SAP Monitor

* Camel case for new fields

* Fixed casing
Remove header/null body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
* changed enum name ruleType to RecommendationType in IoTSecuritySolution RP

* changed examples of IOT security solution RP

* nullable userDefinedResources query/subs

* fixing the Security Solution RP

* Changed the enums of the Recommendations type and status of the IOT Solution Manager RP

* changed property of the recommendation configuration form "description" to "name" in the IOT Solution Manager RP

* Fixed examples of IOT Security Manager RP

* Fixed error in schema related to IoT security Solution RP

* fixed enums in IoT Security solution RP

* fixed spelling mistakes in IoT solution Manager RP files

* Update specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutions.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/IoTSecuritySolutions/CreateIoTSecuritySolution_example.json

Co-Authored-By: Nick Schonning <[email protected]>

* Fixed spelling mistakes in IoT solution manager RP

* Fixed spelling mistakes in IoT solution Manager RP

* removed unprintable characters and tabs from the IoT Security Solution json
* new tag in alerts management

* try to fix errors

* more fixes

* merged action rule and ManagedResource to avoid error

* undo ManagedResource change, but removed required

* revert some changes that are not essential to fix linter

* added supressions
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- Change value to body for WorkflowTriggerHistories_Get
- Remove "description" from OperationList results
- Add body for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- active -> Active for state enum in 2017-09-01 examples
Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE error
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
nschonni and others added 29 commits August 1, 2019 13:32
Fix spelling issues added in #6629 from "example" values in spec
* fix: Microsoft.Sql/stable/2014-04-01 model validation

- RESPONSE_SCHEMA_NOT_IN_SPEC
- RESPONSE_BODY_NOT_IN_EXAMPLE
- Remove "description" not it schema
Other issues not resolved

* fix: sql preview model validation errors

- Remove empty "body" for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- IsAzureMonitorTargetEnabled -> isAzureMonitorTargetEnabled
- "State" -> "state"
- emailAccountAdmins "true" -> true
- Add 202 response for RestorePoints_Create
- password -> certPassword for ManagedInstanceTdeCertificates_Create and TdeCertificates_Create
…6767)

* Re-enable v1 CI pipeline and retarget v2 sdk automation to test repo
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
* add QnAMaker runtime to Go SDK

* ensure package directory and namespace match
Remove empty "body" to fix RESPONSE_SCHEMA_NOT_IN_SPEC errors
* add TriggerRuns_Rerun api

* pr update

* update example
…te (#6683)

* Add terminate notification profile and scheduled events profile to the Microosft.Compute
autorest config.

* Correct definition format

* Update specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

Co-Authored-By: Nick Schonning <[email protected]>

* Add ScheduledEventsProfile to the UpdateVMScaleSetVM model, and add instance
view expansion to get VM Scale Set VM.

* Add an example for terminate scheduled events, and add type:object to scheudled events
and termiante profile schemas.

* Add example reference into compute.json

* Fix example file naming.

* Fix terminate scheduled event reference.
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- "path" -> "folderPath"
- Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- Unstrigify response body values
* RosettaNet Process configuration apis

Integration account - RosettaNet CRUD APIs
Integration account- agreement changes for RosettaNet agreement type.

* updated examples path

* fixes CI errors

Fixed casing as required by CI

* ModelValidation fixes

* merge conflicts resoultion

* CI fixes

* Additional model validation fixes

* test fixes

* operation test fix

* removed breaking changes

* pr feedback

* added custom words for spell check
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
Change "parameters" to "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
* Add way to override the service url

* fix file reference

* removed readonly property
@DanaPeled DanaPeled merged commit 4f1e974 into DanaPeled:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.