-
Notifications
You must be signed in to change notification settings - Fork 19
Fix conversion of String->Int dictionary #53
Conversation
Can you please also add the test of the name to the manifest so that this test is ran on Linux as well? https://github.com/DanToml/Jay/blob/master/Tests/JayTests/FormattingTests.swift#L34 |
Oops, missed that. Fixed. |
I did an explicit typecheck on Note that the inverse (typechecking for |
Note to self: run the full unit test suite before pushing :( Sorry for the noise, back to the drawing board. |
Not sure why the build is failing; the tests seem to pass. |
Current coverage is 88.32% (diff: 81.81%)@@ master #53 diff @@
==========================================
Files 24 24
Lines 1914 1936 +22
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1706 1710 +4
- Misses 208 226 +18
Partials 0 0
|
Any updates on this? Is there anything I can do to get this merged? |
Looks like this will need a rebase then it's good to go, sorry for the delay! |
@dantoml Thanks, done! |
Failing test for #52