Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip embedded class from schema listener #189

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Skip embedded class from schema listener #189

merged 2 commits into from
Dec 19, 2023

Conversation

DamienHarper
Copy link
Owner

This is an updated version of PR #183 from @guillaume-sainthillier

When multiple storage is used, we can't handle embedded classes for a storage manager

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07235c1) 94.40% compared to head (4a436a0) 94.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #189   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          44       44           
  Lines        1823     1823           
=======================================
  Hits         1721     1721           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamienHarper DamienHarper merged commit bdfbaef into 2.x Dec 19, 2023
47 checks passed
@DamienHarper DamienHarper deleted the fix-embed branch December 19, 2023 20:35
DamienHarper added a commit that referenced this pull request Dec 19, 2023
DamienHarper added a commit that referenced this pull request Jul 14, 2024
* Fix bug: exception while creating audit table schema when using single table inheritance (#133)

* fix #132

* entity

Co-authored-by: a.dmitryuk <[email protected]>

* Updated README.md

* Updated CI

* Fixed annotations in tests

* Regression fix.

Fixes DamienHarper/auditor-bundle#334

* Updated CI

* Performance issues with metadatas (#137)

* Cache DH Annotations
* speed
* remove getOwner call

Co-authored-by: a.dmitryuk <[email protected]>

* CreateSchemaListener not updating inheritance tables (#139)

* Fix: Attempted to call an undefined method named "getMetadataCache" of class "Doctrine\ORM\Configuration". (#144)

* Fix: Attempted to call an undefined method named "introspectSchema" of class "Doctrine\DBAL\Schema\PostgreSQLSchemaManager" (#143)

* Fixed invokable storage mapper (see #146) (#148)

* Fixed broken annotation registration since doctrine/orm 2.14

* improved the TransactionProcessor to convert encoding of diff properly (#152)

* improved the TransactionProcessor to convert encoding of diff properly

* adapted quotes in TransactionProcessor to single quotes

* Fixed compatibility issue with doctrine/event-manager ^2.0 (#157)

* PHP-CS-Fixer

* Validate that diff is a string before passing to mb_convert_encoding (#156)

* PHP-CS-Fixer

* Support  doctrine annotations 2.0 (#158)

* topic 344  doctrine annotations 2.0

---------

Co-authored-by: a.dmitryuk <[email protected]>

* PHP-CS-Fixer

* Fix failing CI (lock related)

* PHP-CS-Fixer

* Fixes `diffs` column type when JSON type is supported

* Fixed CI (2.x)

* Fixed CI (2.x)

* Fixed CI (2.x)

* Fixed CI (2.x)

* Fixed CI (2.x)

* Fix 185 (#186)

* fixes #185

* PHP-CS-Fixer

---------

Co-authored-by: Damien Harper <[email protected]>

* skip embedded class from schema listener (#189)

Co-authored-by: Guillaume Sainthillier <[email protected]>

* Fixed CI (2.x)

* Typo

* PHP-CS-Fixer

* Update deps + PHP-CS-Fixer

* PHP-CS-Fixer

* PHP-CS-Fixer (3.48.0)

* Detected wrapped driver (#195)

* - updated DHDriver and use parent::connect instead of dedicated field
- added getWrappedDriver to extract wrapped driver.
- tests

Signed-off-by: Oleg Andreyev <[email protected]>

* Fixed PHPStan error

---------

Signed-off-by: Oleg Andreyev <[email protected]>
Co-authored-by: Damien Harper <[email protected]>

* fix

Signed-off-by: Oleg Andreyev <[email protected]>

* php-cs-fixer

Signed-off-by: Oleg Andreyev <[email protected]>

* removed getSubscribedEvents from CreateSchemaListener

Signed-off-by: Oleg Andreyev <[email protected]>

* phpstan

Signed-off-by: Oleg Andreyev <[email protected]>

* fix DoctrineSubscriber + tests

Signed-off-by: Oleg Andreyev <[email protected]>

* fix Issue174Test

Signed-off-by: Oleg Andreyev <[email protected]>

* removed duplicate code, fixed test

Signed-off-by: Oleg Andreyev <[email protected]>

---------

Signed-off-by: Oleg Andreyev <[email protected]>
Co-authored-by: Alexander Dmitryuk <[email protected]>
Co-authored-by: a.dmitryuk <[email protected]>
Co-authored-by: damienharper <[email protected]>
Co-authored-by: Jörn Dyherrn <[email protected]>
Co-authored-by: Martijn Boers <[email protected]>
Co-authored-by: Guillaume Sainthillier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants