-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid including jQuery #547
Comments
Just for the record, |
Also, I do believe that bootstrap/bootstrap-sass-official are the only packages that depend on jquery |
That's true, but I think the dependency should not be included into the main bower.json. |
I pretty much agree with you @pasine, my only reserve is that angular will use jQuery instead of it's built-in jQuery-lite if jQuery is loaded into the window before angular loads. I'm wondering if switching to strictly jQuery-lite included with angular would cause any problems for users accustomed to full jQuery support with |
I understand, but this should be a generator, a starting point for all users, so IMHO it should be as lean as possible in terms of external resources. |
I completely understand. Care to make a PR? If you do, I'd dare say you could remove jQuery altogether and let the bootstrap dependency bring it in when needed. |
Another potential good point to add to this is: |
I have noticed that running the generator without including Bootstrap causes bower to still loading jQuery: why this? Is it still necessary for something that I am missing?
Another thing: what do you think about switching from angular-ui to angular-strap for handling Boostrap directives? It looks more angular-like and doesn't require jQuery.
The text was updated successfully, but these errors were encountered: