Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(gen): socket.service.js and socket.mock.js are not filtered #530

Closed
kingcody opened this issue Sep 7, 2014 · 1 comment
Closed

bug(gen): socket.service.js and socket.mock.js are not filtered #530

kingcody opened this issue Sep 7, 2014 · 1 comment
Labels

Comments

@kingcody
Copy link
Member

kingcody commented Sep 7, 2014

As the title says, client/components/socket/socket.service.js and client/components/socket/socket.mock.js are not filtered properly with a (js) filter in their file name. This bug is apparent when selecting socket.io and coffee.

kingcody added a commit to kingcody/generator-angular-fullstack that referenced this issue Sep 7, 2014
Changes:
- add `(js)` filter to the js files in `client/components/socket`

Closes angular-fullstack#530
@JaKXz JaKXz added the bug label Sep 8, 2014
kingcody added a commit to kingcody/generator-angular-fullstack that referenced this issue Sep 10, 2014
Changes:
- `genFiles(ops)` creates an array of expected files based on options given
- test for generated files on every set of tests
- test for unexpected files
- use testExec to be more DRY

Exposes a bug with `client/components/socket`:
`socket.service.js` and `socket.mock.js` are not filtered.
See angular-fullstack#530
@kingcody
Copy link
Member Author

Closed by #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants