fix(gen): use bool for bootstrap filters #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaftMonk would you rather use |
|
Ok I was able to reproduce the issue. I was using a different version of the generator. Personally I think !! is more clear. |
Changes: - `filters.bootstrap` and `filters.uibootstrap` will be true or false only Closes angular-fullstack#496
kingcody
force-pushed
the
fix/bootstrap-prompts
branch
from
77469fc
to
a5decbc
Compare
|
Changed ternary to |
|
Build passes here, but |
|
@DaftMonk, just want to point out that the root cause of this issue is:
Since uibootstrap is |
DaftMonk
added a commit
that referenced
this pull request
Aug 29, 2014
fix(gen): use bool for bootstrap filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
filters.bootstrapandfilters.uibootstrapwill be true or false onlyCloses #496