-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator tests pass erroneously? #486
Comments
I see, when testing with |
Adding: it('should pass jshint', function(done) {
this.timeout(60000);
gen.run({}, function () {
exec('grunt jshint', function (error, stdout, stderr) {
expect(stdout).to.contain('Running "jshint:server" (jshint) task\u001b[24m\n\n✔ No problems');
expect(stdout).to.contain('Running "jshint:all" (jshint) task\u001b[24m\n\n✔ No problems');
done();
});
});
}); to line ~80 in |
I can include this fix, along with the lint errors in #482 if others are in agreement that linting with |
Good catch! |
Changes: - Update jshint task in `Gruntfile.js` to include `serverTest` - Add `server/.jshintrc-spec` that extends `server/.jshintrc` with spec globals - Use `"latedef": "nofunc"` instead of `"latedef": true` in `server/.jshintrc` - Add assertion for `jshint` task in generator tests for `defaultOptions` - Fix pre exsisting lint errors in `server` and `client` - Change `getEmail()` in `client/app/account/settings/settings.controller` to use `user` arg and not `$scope.user` Closes angular-fullstack#463, angular-fullstack#486
Closed by #482 |
I was looking at the test for the generator, in particular the
should pass jshint
. All of the test pass when I rungrunt test
in the generator folder (generator-angular-fullstack
). However when icd test/temp && grunt jshint
the taskjshint:all
actually fails. I'm kind of confussed being that it looks liketest/test-file-creation.js
checks to make sure the jshint:all task passes.Anyone have any ideas on this one?
The text was updated successfully, but these errors were encountered: