fix(model): fix update bugs with mongoose and sequelize

angular-fullstack · Jun 22, 2015 · 1805975 · 1805975
1 parent df48188
commit 1805975
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/templates/server/api/user(auth)/user.model(mongooseModels).js b/app/templates/server/api/user(auth)/user.model(mongooseModels).js
@@ -102,7 +102,7 @@ var validatePresenceOf = function(value) {
 UserSchema
   .pre('save', function(next) {
     // Handle new/update passwords
-    if (this.password) {
+    if (this.isModified('password')) {
       if (!validatePresenceOf(this.password)<% if (filters.oauth) { %> && authTypes.indexOf(this.provider) === -1<% } %>) {
         next(new Error('Invalid password'));
       }

diff --git a/app/templates/server/api/user(auth)/user.model(sequelizeModels).js b/app/templates/server/api/user(auth)/user.model(sequelizeModels).js
@@ -89,8 +89,9 @@ module.exports = function(sequelize, DataTypes) {
       },
       beforeUpdate: function(user, fields, fn) {
         if (user.changed('password')) {
-          user.updatePassword(fn);
+          return user.updatePassword(fn);
         }
+        fn();
       }
     },