Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify V-HACD to expose a completion event #1

Open
DaZombieKiller opened this issue Jul 12, 2019 · 1 comment
Open

Modify V-HACD to expose a completion event #1

DaZombieKiller opened this issue Jul 12, 2019 · 1 comment
Assignees
@DaZombieKiller
Labels
good first issue Good for newcomers

Comments

@DaZombieKiller
Copy link
Owner

Currently, Task.Run is used to avoid blocking while V-HACD runs. This is very much not ideal, as it consumes a ThreadPool thread.

This is only done because V-HACD exposes no completion event that can be subscribed to, instead only offering an IsReady boolean for polling.

At some point, V-HACD itself should be modified to include a completion event, and ComputeAsync can be modified to subscribe to it with TaskCompletionSource.
@DaZombieKiller DaZombieKiller self-assigned this Jul 12, 2019
@DaZombieKiller DaZombieKiller added the good first issue Good for newcomers label Jul 12, 2019
@DaZombieKiller
Copy link
Owner Author

Usage of Task.Run was addressed in ef3694d. Now the function simply Task.Yields during each iteration of the IsReady loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaZombieKiller DaZombieKiller

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DaZombieKiller