Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol rust_crypto_util_fixed_time_eq_asm missing for aarch64 builds #383

Open
zacstewart opened this issue Aug 14, 2016 · 3 comments · May be fixed by #384
Open

Symbol rust_crypto_util_fixed_time_eq_asm missing for aarch64 builds #383

zacstewart opened this issue Aug 14, 2016 · 3 comments · May be fixed by #384

Comments

@zacstewart
Copy link

zacstewart commented Aug 14, 2016 •
edited
Loading

I might have the wrong place, but I think I've narrowed a failing build down to this helper function not being compiled for arm64.

I'm trying to build a project that depends on rust-crypto for multiple Apple iOS targets and combine the archives using lipo. Everything seems to go well until building the final product with XCode:

undefined symbols for architecture arm64:
  "_rust_crypto_util_fixed_time_eq_asm", referenced from:
      crypto::util::fixed_time_eq::hd6fee48f285f2cc2 in libcomm.a(crypto-b53f4f52658d6577.0.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

If I remove arm64 from my XCode targets (leaving arm7 and arm7s) it works fine. Is it possible that this function only compiles for 32-bit ARM architecture?
@zacstewart
Copy link
Author

I think I may have a fix for this. Opening a PR.

@zacstewart zacstewart linked a pull request Aug 14, 2016 that will close this issue
Open
@debris
Copy link

debris commented Feb 20, 2017

I stumbled upon the same issue. Is there any reason, why pr with the fix is not merged?

@hlzhang hlzhang mentioned this issue May 27, 2017
Closed
@newpavlov
Copy link

@debris
rust-crypto is no longer maintained. RustCrypto aims to succeed it.

posborne added a commit to posborne/rust-s3 that referenced this issue Jun 7, 2017
@posborne
crypto: use RustCrypto utils over deprecated rust-crypto
b12cc59 
This change started due to my unfortunate exposure to a bug impacting
the ability for my project to target aarch64:
DaGenix/rust-crypto#383.

In that issue (and in others) it is clear that rust-crypto is now
deprecated in favor of the RustCrypto crates (here we need sha2/hmac).
This change drops in this replacement for rust-crypto.

Signed-off-by: Paul Osborne <[email protected]>
posborne added a commit to posborne/rust-s3 that referenced this issue Jun 7, 2017
@posborne
crypto: use RustCrypto utils over deprecated rust-crypto
6f25fbe 
This change started due to my unfortunate exposure to a bug impacting
the ability for my project to target aarch64:
DaGenix/rust-crypto#383.

In that issue (and in others) it is clear that rust-crypto is now
deprecated in favor of the RustCrypto crates (here we need sha2/hmac).
This change drops in this replacement for rust-crypto.

Signed-off-by: Paul Osborne <[email protected]>
@posborne posborne mentioned this issue Jun 7, 2017
Merged
niluxv pushed a commit to niluxv/rust-crypto that referenced this issue Aug 15, 2018
@hlzhang @niluxv
fix DaGenix#383
bba1031
@mprasil mprasil mentioned this issue Nov 20, 2018
Closed
@mcrosson mcrosson mentioned this issue Dec 10, 2018
Closed
@artemii235 artemii235 mentioned this issue Mar 25, 2019
Closed
@sgn sgn mentioned this issue Jul 15, 2020
Closed
@MuhtasimTanmoy MuhtasimTanmoy mentioned this issue Mar 1, 2023
Open
@thearossman thearossman mentioned this issue Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@newpavlov @zacstewart @debris