Cache/v1.0.14 #797
Merged
Cache/v1.0.14 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossneilson
reviewed
Apr 18, 2022
| @@ -54,7 +54,7 @@ const Web3ReactManager = ({ children }) => { | |||
| // If eager-connect failed, try to connect to network in the URL | |||
| // If no chain in the URL, fallback to default chain | |||
| useEffect(() => { | |||
| if (triedEager && !networkActive && rpcUrls) { | |||
| if (!networkActive && rpcUrls) { | |||
There was a problem hiding this comment.
You really want rid of this dont you?
There was a problem hiding this comment.
ups, doing rebase and using last commit only nowwwww
There was a problem hiding this comment.
done, we good now, only one commit updating caches
MiltonTulli
approved these changes
Apr 18, 2022
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: e714f64 😎 Browse the preview: https://bafybeifnsmv22d36tyrjqx4uf5ynnkdraealabfhg6g4cmgyqb44imqxge.ipfs.dweb.link |
rossneilson
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hashed and verified with @rossneilson and @MiltonTulli
Cache default config file: https://gateway.pinata.cloud/ipfs/QmejrErKD3PYYmNUGDzKXwMgtdpHo1hSxC9MFCqPFxc1GL
After this PR, teh cache.dxvote.eth link (with ens node
0x331cd7edaf3b957429977bd70caeec3e325661ef642c3d06255445f2c4051bc3) has to be set toe30101701220f3ac62f390d9373a5ae95ef228bc4031b3fe72027513acca21846bf5e1ea8ca1(content hash ofQmejrErKD3PYYmNUGDzKXwMgtdpHo1hSxC9MFCqPFxc1GL)Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: