Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote calculation for snapshot implementation #776

Conversation

MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented Apr 6, 2022

Description

Modify calculation to return totalLocked including snapshot guilds ( using totalLocked at proposal snapshot). Proposal page is not showing user voting power so didn't update UI for that but created required hook for that call.

  • Refactor dev script:
    • Create snapshotERC20 Guild instance proposal
    • Create accounts array to reuse
  • Include json contracts:
    • SnapshotERC20Guild.json
    • ERC20SnapshotRep.json
    • SnapshotRepERC20Guild.json
  • Refactor useGuildConfig hook to use new useTotalLocked hook.
  • Create useVotingPowerOfAt hook -> get votingpower of user at snapshot
  • Create useSnapshotID hook -> get snapshot id at proposal snapshot
  • Create useTotalLockedAt hook -> Get totalLocked at proposal snapshot
  • Create useTotalLocked hook to use with multiple guild implementations.
  • Create useGuildToken hook
  • Create useTotalSupplyAt.ts

Closes #745

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

✔️ Preview deployment is ready!

🔨 Explore the source changes: b27c8c9

😎 Browse the preview: https://bafybeifeyq2n2ubusum3amvyso6nn7vbkfz4x3tkthpylujrixpt2bhaqq.ipfs.dweb.link

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

✔️ Preview deployment is ready!

🔨 Explore the source changes: 37e0dfa

😎 Browse the preview: https://bafybeiawkvxbql6ybojs54cojyynucxtepbhslbwkwypoujfffyts2fjeq.ipfs.dweb.link

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

✔️ Preview deployment is ready!

🔨 Explore the source changes: 1d986ee

😎 Browse the preview: https://bafybeihoffiwk3xxsm3quod3ucg25cwcl7letbxzv3ymgilk6aqzrhskb4.ipfs.dweb.link

…uildToken hook, create a useTotalSupplyAt hook.
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

✔️ Preview deployment is ready!

🔨 Explore the source changes: 1dbc7c5

😎 Browse the preview: https://bafybeigqjmewo5jsalm64xhmzwhkmbrh6lprhd6pqfi4qp2yshgreglnii.ipfs.dweb.link

@MiltonTulli MiltonTulli changed the title [WIP] Feature/vote calculation for snapshot implementation Feature/vote calculation for snapshot implementation Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

✔️ Preview deployment is ready!

🔨 Explore the source changes: e8b3df7

😎 Browse the preview: https://bafybeif3bzy5m4m3m4r5xhm6ibjiuy6b4vu47v56ers4477nawtxhzzkwa.ipfs.dweb.link

@MiltonTulli MiltonTulli merged commit e2a61dd into DXgovernance:develop Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants