Remove AccountType (#2420)

src/main/java/net/dv8tion/jda/api/JDA.java

@@ -1862,23 +1862,11 @@ default List<RichCustomEmoji> getEmojisByName(@Nonnull String name, boolean igno
     // */
     //AuditableRestAction<Void> installAuxiliaryCable(int port);
 
-    /**
-     * The {@link net.dv8tion.jda.api.AccountType} of the currently logged in account.
-     * <br>Used when determining functions that are restricted based on the type of account.
-     *
-     * @return The current AccountType.
-     */
-    @Nonnull
-    AccountType getAccountType();
-
     /**
      * Retrieves the {@link ApplicationInfo ApplicationInfo} for
      * the application that owns the logged in Bot-Account.
      * <br>This contains information about the owner of the currently logged in bot account!
      *
-     * @throws net.dv8tion.jda.api.exceptions.AccountTypeException
-     *         If the currently logged in account is not from {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
-     *
      * @return {@link net.dv8tion.jda.api.requests.RestAction RestAction} - Type: {@link ApplicationInfo ApplicationInfo}
      *         <br>The {@link ApplicationInfo ApplicationInfo} of the bot's application.
      */
@@ -1931,9 +1919,6 @@ default JDA setRequiredScopes(@Nonnull String... scopes)
      *         The permissions to use in your invite, these can be changed by the link user.
      *         <br>If no permissions are provided the {@code permissions} parameter is omitted
      *
-     * @throws net.dv8tion.jda.api.exceptions.AccountTypeException
-     *         If the currently logged in account is not from {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
-     *
      * @return A valid OAuth2 invite url for the currently logged in Bot-Account
      */
     @Nonnull
@@ -1950,9 +1935,6 @@ default JDA setRequiredScopes(@Nonnull String... scopes)
      *         The permissions to use in your invite, these can be changed by the link user.
      *         <br>If no permissions are provided the {@code permissions} parameter is omitted
      *
-     * @throws net.dv8tion.jda.api.exceptions.AccountTypeException
-     *         If the currently logged in account is not from {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
-     *
      * @return A valid OAuth2 invite url for the currently logged in Bot-Account
      */
     @Nonnull

src/main/java/net/dv8tion/jda/api/JDABuilder.java

@@ -828,7 +828,7 @@ public JDABuilder setRequestTimeoutRetry(boolean retryOnTimeout)
      * Sets the token that will be used by the {@link net.dv8tion.jda.api.JDA} instance to log in when
      * {@link net.dv8tion.jda.api.JDABuilder#build() build()} is called.
      *
-     * <p><b>For {@link net.dv8tion.jda.api.AccountType#BOT}</b><br>
+     * <p>To get a bot token:<br>
      * <ol>
      *     <li>Go to your <a href="https://discord.com/developers/applications/me">Discord Applications</a></li>
      *     <li>Create or select an already existing application</li>

src/main/java/net/dv8tion/jda/api/entities/Guild.java

@@ -4057,7 +4057,6 @@ default AuditableRestAction<Void> modifyMemberRoles(@Nonnull Member member, @Non
      *         <ul>
      *             <li>If the specified Member is {@code null} or not from the same Guild</li>
      *             <li>If the specified Member already is the Guild owner</li>
-     *             <li>If the specified Member is a bot account ({@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT})</li>
      *         </ul>
      *
      * @return {@link net.dv8tion.jda.api.requests.restaction.AuditableRestAction AuditableRestAction}

src/main/java/net/dv8tion/jda/api/entities/MessageEmbed.java

@@ -15,6 +15,7 @@
  */
 package net.dv8tion.jda.api.entities;
 
+import net.dv8tion.jda.annotations.ForRemoval;
 import net.dv8tion.jda.api.EmbedBuilder;
 import net.dv8tion.jda.api.utils.AttachmentProxy;
 import net.dv8tion.jda.api.utils.ImageProxy;
@@ -92,7 +93,6 @@ public class MessageEmbed implements SerializableData
 
     /**
      * The maximum amount of total visible characters an embed can have
-     * <br>This limit depends on the current {@link net.dv8tion.jda.api.AccountType AccountType} and applies to BOT
      *
      * @see net.dv8tion.jda.api.EmbedBuilder#setDescription(CharSequence)
      * @see net.dv8tion.jda.api.EmbedBuilder#setTitle(String)
@@ -103,13 +103,16 @@ public class MessageEmbed implements SerializableData
 
     /**
      * The maximum amount of total visible characters an embed can have
-     * <br>This limit depends on the current {@link net.dv8tion.jda.api.AccountType AccountType} and applies to CLIENT
      *
      * @see net.dv8tion.jda.api.EmbedBuilder#setDescription(CharSequence)
      * @see net.dv8tion.jda.api.EmbedBuilder#setTitle(String)
      * @see net.dv8tion.jda.api.EmbedBuilder#setFooter(String, String)
      * @see net.dv8tion.jda.api.EmbedBuilder#addField(String, String, boolean)
+     *
+     * @deprecated This will be removed in the future.
      */
+    @Deprecated
+    @ForRemoval
     public static final int EMBED_MAX_LENGTH_CLIENT = 2000;
 
     protected final Object mutex = new Object();

src/main/java/net/dv8tion/jda/api/entities/channel/concrete/ThreadChannel.java

@@ -208,8 +208,6 @@ default GuildMessageChannelUnion getParentMessageChannel()
      *     <br>The request was attempted after the parent channel was deleted.</li>
      * </ul>
      *
-     * @throws net.dv8tion.jda.api.exceptions.AccountTypeException
-     *         If the currently logged in account is not from {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
      * @throws net.dv8tion.jda.api.exceptions.InsufficientPermissionException
      *         If this is a {@link GuildMessageChannel GuildMessageChannel} and the logged in account does not have
      *         <ul>

src/main/java/net/dv8tion/jda/api/entities/channel/middleman/MessageChannel.java

@@ -15,7 +15,6 @@
  */
 package net.dv8tion.jda.api.entities.channel.middleman;
 
-import net.dv8tion.jda.api.AccountType;
 import net.dv8tion.jda.api.entities.Guild;
 import net.dv8tion.jda.api.entities.Message;
 import net.dv8tion.jda.api.entities.MessageEmbed;
@@ -25,7 +24,6 @@
 import net.dv8tion.jda.api.entities.channel.concrete.TextChannel;
 import net.dv8tion.jda.api.entities.channel.concrete.ThreadChannel;
 import net.dv8tion.jda.api.entities.emoji.Emoji;
-import net.dv8tion.jda.api.exceptions.AccountTypeException;
 import net.dv8tion.jda.api.interactions.components.ActionRow;
 import net.dv8tion.jda.api.interactions.components.LayoutComponent;
 import net.dv8tion.jda.api.interactions.components.buttons.Button;
@@ -753,8 +751,6 @@ default MessageCreateAction sendFiles(@Nonnull FileUpload... files)
      * @param  messageId
      *         The id of the sought after Message
      *
-     * @throws net.dv8tion.jda.api.exceptions.AccountTypeException
-     *         If the currently logged in account is not from {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
      * @throws IllegalArgumentException
      *         if the provided {@code messageId} is null or empty.
      * @throws net.dv8tion.jda.api.exceptions.InsufficientPermissionException
@@ -771,7 +767,6 @@ default MessageCreateAction sendFiles(@Nonnull FileUpload... files)
     @CheckReturnValue
     default RestAction<Message> retrieveMessageById(@Nonnull String messageId)
     {
-        AccountTypeException.check(getJDA().getAccountType(), AccountType.BOT);
         Checks.isSnowflake(messageId, "Message ID");
 
         JDAImpl jda = (JDAImpl) getJDA();
@@ -809,8 +804,6 @@ default RestAction<Message> retrieveMessageById(@Nonnull String messageId)
      * @param  messageId
      *         The id of the sought after Message
      *
-     * @throws net.dv8tion.jda.api.exceptions.AccountTypeException
-     *         If the currently logged in account is not from {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
      * @throws net.dv8tion.jda.api.exceptions.InsufficientPermissionException
      *         If this is a {@link GuildMessageChannel GuildMessageChannel} and the logged in account does not have
      *         <ul>

src/main/java/net/dv8tion/jda/api/requests/restaction/AuditableRestAction.java

@@ -28,7 +28,7 @@
 import java.util.function.BooleanSupplier;
 
 /**
- * Extension of RestAction to allow setting a reason, only available to accounts of {@link net.dv8tion.jda.api.AccountType#BOT AccountType.BOT}
+ * Extension of RestAction to allow setting a reason.
  *
  * <p>This will automatically use the {@link net.dv8tion.jda.api.audit.ThreadLocalReason ThreadLocalReason} if no
  * reason was specified via {@link #reason(String)}.

src/main/java/net/dv8tion/jda/api/utils/SessionControllerAdapter.java

@@ -17,9 +17,7 @@
 package net.dv8tion.jda.api.utils;
 
 import com.neovisionaries.ws.client.OpeningHandshakeException;
-import net.dv8tion.jda.api.AccountType;
 import net.dv8tion.jda.api.JDA;
-import net.dv8tion.jda.api.exceptions.AccountTypeException;
 import net.dv8tion.jda.api.exceptions.InvalidTokenException;
 import net.dv8tion.jda.api.requests.Request;
 import net.dv8tion.jda.api.requests.Response;
@@ -75,7 +73,6 @@ public RestRateLimiter.GlobalRateLimit getRateLimitHandle()
     @Override
     public ShardedGateway getShardedGateway(@Nonnull JDA api)
     {
-        AccountTypeException.check(api.getAccountType(), AccountType.BOT);
         return new RestActionImpl<ShardedGateway>(api, Route.Misc.GATEWAY_BOT.compile())
         {
             @Override

src/main/java/net/dv8tion/jda/internal/JDAImpl.java

@@ -18,7 +18,6 @@
 
 import com.neovisionaries.ws.client.WebSocketFactory;
 import gnu.trove.set.TLongSet;
-import net.dv8tion.jda.api.AccountType;
 import net.dv8tion.jda.api.GatewayEncoding;
 import net.dv8tion.jda.api.JDA;
 import net.dv8tion.jda.api.Permission;
@@ -36,7 +35,6 @@
 import net.dv8tion.jda.api.events.GenericEvent;
 import net.dv8tion.jda.api.events.StatusChangeEvent;
 import net.dv8tion.jda.api.events.session.ShutdownEvent;
-import net.dv8tion.jda.api.exceptions.AccountTypeException;
 import net.dv8tion.jda.api.exceptions.InvalidTokenException;
 import net.dv8tion.jda.api.exceptions.ParsingException;
 import net.dv8tion.jda.api.exceptions.RateLimitedException;
@@ -946,13 +944,6 @@ public IEventManager getEventManager()
         return eventManager.getSubject();
     }
 
-    @Nonnull
-    @Override
-    public AccountType getAccountType()
-    {
-        return authConfig.getAccountType();
-    }
-
     @Override
     public void setEventManager(IEventManager eventManager)
     {
@@ -1126,7 +1117,6 @@ public RestAction<Webhook> retrieveWebhookById(@Nonnull String webhookId)
     @Override
     public RestAction<ApplicationInfo> retrieveApplicationInfo()
     {
-        AccountTypeException.check(getAccountType(), AccountType.BOT);
         Route.CompiledRoute route = Route.Applications.GET_BOT_APPLICATION.compile();
         return new RestActionImpl<>(this, route, (response, request) ->
         {

src/main/java/net/dv8tion/jda/internal/requests/WebSocketClient.java

@@ -19,7 +19,10 @@
 import com.neovisionaries.ws.client.*;
 import gnu.trove.iterator.TLongObjectIterator;
 import gnu.trove.map.TLongObjectMap;
-import net.dv8tion.jda.api.*;
+import net.dv8tion.jda.api.GatewayEncoding;
+import net.dv8tion.jda.api.JDA;
+import net.dv8tion.jda.api.JDAInfo;
+import net.dv8tion.jda.api.Permission;
 import net.dv8tion.jda.api.audio.hooks.ConnectionListener;
 import net.dv8tion.jda.api.audio.hooks.ConnectionStatus;
 import net.dv8tion.jda.api.entities.Guild;
@@ -817,9 +820,8 @@ protected void updateAudioManagerReferences()
 
     protected String getToken()
     {
-        if (api.getAccountType() == AccountType.BOT)
-            return api.getToken().substring("Bot ".length());
-        return api.getToken();
+        // all bot tokens are prefixed with "Bot "
+        return api.getToken().substring("Bot ".length());
     }
 
     protected List<DataObject> convertPresencesReplace(long responseTotal, DataArray array)

src/main/java/net/dv8tion/jda/internal/utils/config/AuthorizationConfig.java

@@ -16,7 +16,6 @@
 
 package net.dv8tion.jda.internal.utils.config;
 
-import net.dv8tion.jda.api.AccountType;
 import net.dv8tion.jda.internal.utils.Checks;
 
 import javax.annotation.Nonnull;
@@ -32,12 +31,6 @@ public AuthorizationConfig(@Nonnull String token)
         setToken(token);
     }
 
-    @Nonnull
-    public AccountType getAccountType()
-    {
-        return AccountType.BOT;
-    }
-
     @Nonnull
     public String getToken()
     {