Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded geometry assumptions from geometry resource #98

Open
krwood opened this issue Jan 24, 2024 · 1 comment
Open

remove hardcoded geometry assumptions from geometry resource #98

krwood opened this issue Jan 24, 2024 · 1 comment

Comments

@krwood
Copy link
Member

krwood commented Jan 24, 2024

We should have a common geometry resource module (living somewhere like ndlar_flow/src/common/resource/geometry.py) that is completely void of any hardcoded assumptions about the geometry, and takes everything in from the appropriate yaml. For example, there are hardcoded assumptions about number of tiles per module and number of modules per detector here: https://github.com/DUNE/ndlar_flow/blob/develop/src/proto_nd_flow/resources/geometry.py#L730C69-L734

@krwood
Copy link
Member Author

krwood commented Jan 24, 2024

@alexbooth92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant