Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box-Art Reimplementation #2060

Open
NightScript370 opened this issue Sep 29, 2022 · 0 comments
Open

Box-Art Reimplementation #2060

NightScript370 opened this issue Sep 29, 2022 · 0 comments

Comments

@NightScript370
Copy link
Member

Is your feature request related to a problem? Please describe.
Seeing a bunch of question-mark box art is not pleasant on the eyes when there aren't any box art images. However, the recent commit which disabled it means that it now receives a ton of less exposure.
Also, cached box art just cache's everything in the beginning, even if it's a ROM icon that doesn't need to be loaded. At the same time, though, there's already a progressive loading system for the icons on the touch screen we could just plug in.

Describe the solution you'd like

  • Get rid of the questioned box art icon for the DSi-based themes (this isn't trying to exclude the other themes, since they don't have any box art but rather, it's trying to exclude the DS Classic Menu, which for the time being has nothing on the top screen. Once the clock gets implemented, then get rid of box art from there). We already have a picture that should be seen, so why overlay that?
  • Get rid of the dedicated box art pre-load option. While it isn't a bottleneck when navigating the ROMs, it's an annoying bottleneck when loading the folder, especially considering it's loading the boxart for options that will not even be navigated. Instead, just use the same system used for icons to load box art for DSi systems
  • Revert the commit that disabled it by default. If it's not a disturbance, why remove?

Describe alternatives you've considered
Change the default to be based on files existing or not. I suggested that but now I disagree; if people didn't set up twilight well before, they would still be unaware

Additional context
Might need ways to make it so that box art is loaded for some icon entries and not to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant