Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropped ISIS Cube and ALE Generated ISD #601

Open
jlaura opened this issue Apr 2, 2024 · 0 comments
Open

Cropped ISIS Cube and ALE Generated ISD #601

jlaura opened this issue Apr 2, 2024 · 0 comments
Assignees

Comments

@jlaura
Copy link
Collaborator

jlaura commented Apr 2, 2024

When running the following pipeline, I am getting unexpected results. Talking with @acpaquette these results are sensical because of how ISIS implements cropping.

Here is the pipeline:

  • Generate an ISIS cube
  • Crop the cube and propagate SPICE
  • Use isd_generate to create an ISD from the cropped cube

My expected behavior is that the ISD generated by isd_generate will be appropriate to use with the cropped ISIS cube. By appropriate, I mean that a campt call and some knoten sensor model function will return the same results, plus or minus the accepted tolerance. In reality, the results are quite different. Why?

ISIS tracks the offsets in the cropped cube and carries around the full observation SPICE. Therefore, the ISD created by ALE is the full observation SPICE. But, the cropped cube is just that, a cropped image. The CSM has no idea that the ISD is provided for an uncropped image.

The result is that a test to ensure that say, pixel (10,10) in the cropped ISIS image returns the same lon/lat between both campt and knoten requires that I add whatever the start sample/line used for the crop command. That information is not recorded in the ISD. It is available via cathist.

I do not know that I have a suggested fix. Options that come to mind (without a lot of thought about the trickle down effects):

  • "Fix" ISIS so that a cropped cube crops the SPICE as well. (I say "fix" because I think ISIS is working as intended.)
  • Fix isd_generate to create a proper cropped ISD if the input ISIS cube is cropped
@antonhibl antonhibl self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants