Add filename prefix option for tgocassisstitch #5125
Assignees
Labels
enhancement
New feature or request
in progress
doing the things
inactive
Issue that has been inactive for at least 6 months
Comments
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
Feb 24, 2023
I still need to implement the logic for tagging on the suffix to the output
file so this is not completely done yet but it begins to address DOI-USGS#5125.
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
Feb 24, 2023
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or suffix option when stitching frames together, just use OUTPUTSUFFIX instead of OUTPUTPREFIX to use it.
12 tasks
12 tasks
|
should be addressed by #5132 |
|
We should leave this issue open until the PR is merged |
|
@antonhibl It looks like I didn't fully capture the request in the original issue. I updated the issue after re-reading the email with the issue description. The other part of this issue (alongside the prefix/suffix specification) is to switch the filename to that of the input e.g. stitch-MY36_018816_356_1_001.cub as opposed to the timestamp e.g. stitch-2022-02-10T12:29:55.286.cub. |
|
@AustinSanders gotcha, that makes sense; I'll take another look. |
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
Mar 24, 2023
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or suffix option when stitching frames together, just use OUTPUTSUFFIX instead of OUTPUTPREFIX to use it.
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
Mar 28, 2023
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or suffix option when stitching frames together, just use OUTPUTSUFFIX instead of OUTPUTPREFIX to use it.
12 tasks
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
May 23, 2023
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or suffix option when stitching frames together, just use OUTPUTSUFFIX instead of OUTPUTPREFIX to use it.
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
Aug 22, 2023
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or suffix option when stitching frames together, just use OUTPUTSUFFIX instead of OUTPUTPREFIX to use it.
antonhibl
added a commit
to antonhibl/ISIS3
that referenced
this issue
Aug 22, 2023
added suffix and prefix capabilities in tgocassisstitch
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or
suffix option when stitching frames together, just use OUTPUTSUFFIX instead
of OUTPUTPREFIX to use it.
minor fixes
typo
more typos
close to done, one error left
need to figure out a replacement for ui.IsOptionSet as that is not actually
a function. I need another way to test CLLI args.
final fixes to implement ui changes
fixed
now employs a boolean flag to decide if the name parsed with out is a suffix
or prefix, it defaults to a prefix.
adding some tests to confirm output runs as expected.
antonhibl
added a commit
that referenced
this issue
Aug 22, 2023
* Squashing things
added suffix and prefix capabilities in tgocassisstitch
addresses #5125, this allows the user to optionally use either the prefix or
suffix option when stitching frames together, just use OUTPUTSUFFIX instead
of OUTPUTPREFIX to use it.
minor fixes
typo
more typos
close to done, one error left
need to figure out a replacement for ui.IsOptionSet as that is not actually
a function. I need another way to test CLLI args.
final fixes to implement ui changes
fixed
now employs a boolean flag to decide if the name parsed with out is a suffix
or prefix, it defaults to a prefix.
adding some tests to confirm output runs as expected.
* adding to changelog
* modified to allow prefix, suffix, both, or neither for better extensibility
it also maintains original value names so older scripts and pipelines will
retain functionality.
adds another optional arg, cubename
lets the user specify an optional cubename parameter which replaces the
timestamp style naming for the output stitched cube. If the parameter is not
given it defaults to the timestamp style naming convention for retaining
existing functionality.
* added details to changelog
removed debugging code
added changelog notes to xml for tgocassisstitch
* typo in changelog
* fixes from review
added cubename argument logic
typo in else statement
* modifying tests
removed faulty/old tests based on makefiles
fixed single and multi frame tests for tgocassisstitch
remaining tests fixed, one on EFS to check with jenkins.
removed debug lines
updated to remove nil randomly appearing in tests
modified first stitch test to use fallback naming behaviour.
* simplified some logic and removed repeat lines in different logic branches
removing redundant lines from 8.0 release
addresses prefix and filename convention topical issues
* resolving changelog merge conflicts (I think)
added details to changelog
small typo in link
* removed some dashes in tests and replaced a mistaken default filename
* fixing the changleog resolves
* modified to allow prefix, suffix, both, or neither for better extensibility
it also maintains original value names so older scripts and pipelines will
retain functionality.
* added details to changelog
changelog fixes
removed typo
* small test changes
* cleaning up git artifacts left by squashing
* changelog resolves
|
Thank you for your contribution! Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.' If no additional action is taken, this issue will be automatically closed in 180 days. If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here. Read more about our support processs here |
github-actions
bot
added
the
inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
tgocassissitch currently produces filenames according to a timestamp rather than preserving the observation-framelet name that is commonly found on TGO images. This is inconvenient and makes it difficult to determine which input and output images correspond.
Instead, it would be nice to have a prefix and/or suffix specification that preserves the original filename and simply adds the specified text to the filename.
Example
tgocassisstitch from= stitch_001.lis outputprefix=stitch
for stitch_001.lis containing:
MY36_018816_356_1_001_PAN00-C1.cub
outputs:
stitch-MY36_018816_356_1_001.cub
The text was updated successfully, but these errors were encountered: