From 855f0372fad6c4121f2cc40f8254a76574d61f31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jerry=20Lundstr=C3=B6m?= Date: Fri, 30 Aug 2024 09:58:26 +0200 Subject: [PATCH] CodeQL - Fix https://github.com/DNS-OARC/dsc/security/code-scanning/20 --- src/pcap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/pcap.c b/src/pcap.c index a071febb..08f89c60 100644 --- a/src/pcap.c +++ b/src/pcap.c @@ -381,8 +381,7 @@ pcap_handle_tcp_segment(u_char* segment, int len, uint32_t seq, tcpstate_t* tcps for (s = 0; s < MAX_TCP_SEGS; s++) { if (!tcpstate->segbuf[s]) continue; - /* TODO: seq >= 0 */ - if (tcpstate->segbuf[s]->seq - seq > 0 && tcpstate->segbuf[s]->seq - seq < dnslen) { + if ((int64_t)tcpstate->segbuf[s]->seq - seq > 0 && (int64_t)tcpstate->segbuf[s]->seq - seq < dnslen) { tcp_segbuf_t* segbuf = tcpstate->segbuf[s]; tcpstate->segbuf[s] = NULL; dfprintf(1, "pcap_handle_tcp_segment: %s", "message reassembled");