Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flood control does not take Replies into account #81

Closed
Timo-Breumelhof opened this issue Apr 23, 2021 · 1 comment · Fixed by #249
Closed

Flood control does not take Replies into account #81

Timo-Breumelhof opened this issue Apr 23, 2021 · 1 comment · Fixed by #249
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Apr 23, 2021

Describe the bug

While fixing #79
I noticed that replies are not accounted for the check for the flood control.
The reason for this is that while saving a reply, the LastPostDate is not saved.
And that's used for the Flood test.

Software Versions

  • DNN: 09.08.00
  • Module: 06.05.01

To Reproduce

Steps to reproduce the behavior:
See #79, notice that Replies don't fire the Flood control.

Expected behavior

So there are a few questions:
A. Do we want Replies to taken into account for Flood control?
B. If yes, how do we support this?
IMO We should add a DB field LastReplyDate and add that to the Flood check. Thought?

@hismightiness @skamphuis

@Timo-Breumelhof Timo-Breumelhof self-assigned this Apr 23, 2021
@Timo-Breumelhof Timo-Breumelhof added the bug Something isn't working label Apr 23, 2021
@WillStrohl
Copy link
Member

Yes, I think we definitely should add that field and include replies in the flood control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants