Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: indicate status of a forums using a class #468

Closed
Timo-Breumelhof opened this issue Sep 18, 2023 · 4 comments · Fixed by #1058
Closed

Question: indicate status of a forums using a class #468

Timo-Breumelhof opened this issue Sep 18, 2023 · 4 comments · Fixed by #1058
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Sep 18, 2023

Please summarize your question in one sentence

  • I did not check yet, just logging... so it might be that we already have this option..
    Should we have a token for a forum / thread status?

Give a more extended description

Thinking about #467 a bit more.
A forum / Thread has a status for a user.
Like 0 threads, 1+ threads, all read some not read etc.
We now indicate this by rendering another icon.
I think it would be useful if we had a token that renders a state class.
Like

dcf-unread
dcf-read

etc. (just a suggestion, I guess we can come up with better terms)

That way a theme developer could add a class to the wrapping div and style the whole row and / or overrule the icons we currently use.

@Timo-Breumelhof Timo-Breumelhof added the question Further information is requested label Sep 18, 2023
@Timo-Breumelhof Timo-Breumelhof added this to the 09.00.00 milestone Sep 18, 2023
@johnhenley johnhenley added the enhancement New feature or request label Sep 20, 2023
@johnhenley
Copy link
Collaborator

I think we'd want to denote unread topics vs forum with unread topics. New topics and new replies. All probably could have their own classes which theme builders could use to style as desired.

@Timo-Breumelhof
Copy link
Contributor Author

Agreed

@WillStrohl
Copy link
Member

This is a good one! 😊

@johnhenley johnhenley modified the milestones: 09.00.00, 08.02.00, 08.03.00 Jul 24, 2024
@johnhenley johnhenley modified the milestones: 08.03.00, 08.02.00 Aug 6, 2024
@johnhenley
Copy link
Collaborator

johnhenley commented Aug 6, 2024

@Timo-Breumelhof I know we have discussed adding "block tokens" like this to include/exclude template sections:

[WHEN:UNREAD:TOPICS] ... [/WHEN:UNREAD:TOPICS]

[WHEN:ALL:TOPICS:READ] ... [/WHEN:ALL:TOPICS:READ]

[WHEN:NEW:TOPICS] ... [/WHEN:NEW:TOPICS]

But for now I want to just get the CSS classes in that you want:

Forums view:

You add a token to template:
<div class="[FORUM:STATUSCSSCLASS]">

[FORUM:STATUSCSSCLASS] gets replaced with:

  • dcf-forumstatus-no-access (you have "view" but not "read" access--IMHO we should just remove one)
  • dcf-forumstatus-no-topics (forum is empty)
  • dcf-forumstatus-new-topics (last post in forum > user's last read post)
  • dcf-forumstatus-unread-topics (user has read newer posts but hasn't read every topic)
  • dcf-forumstatus-all-topics-read (user has read every topic in forum)

Topics view:
<div class="[FORUMTOPIC:STATUSCSSCLASS]">

  • dcf-topicstatus-new (post > user's last read post; user hasn't read at all or may have read original post and earlier replies but there are new replies)
  • dcf-topicstatus-unread (user hasn't read at all)
  • dcf-topicstatus-read (user is up-to-date on topic and any replies)
  • dcf-topicstatus-authored (user is the one who created it)

This may result in multiple variations such as unread + authored.

Topic view template:
<div class="[FORUMPOST:STATUSCSSCLASS]">

  • dcf-poststatus-new (post/reply > user's last read post)
  • dcf-poststatus-unread (user hasn't read)
  • dcf-poststatus-read
  • dcf-poststatus-authored (user is the one who created it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants