Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingering references in mails to the 'write plan' tab which no longer exists #90

Open
TheLisaVL opened this issue Oct 19, 2023 · 4 comments
Labels
good first issue Good for newcomers roadmap Issue to be handled upstream

Comments

@TheLisaVL
Copy link
Collaborator

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

Expected behaviour:
References to the 'write plan' tab are gone since we no longer use it.

Actual behaviour:
Mail templates still contain references to the 'write plan' tab, even though it no longer exists.
Example:
Hello XXX
XXX has finished providing feedback on the plan "XXX". Comments can be found in the 'Write plan' tab on the right side of the page (Guidance/Comments).
All the best
The DMPonline.be team
You may change your notification preferences on your profile page. Please do not reply to this email. If you have any questions or need help, please contact us at [email protected] or visit https://dmponline.be/contact-us

Steps to reproduce:
Provide feedback on a plan. References might also still exist in other templates, to be investigated.

@TheLisaVL TheLisaVL added the good first issue Good for newcomers label Oct 19, 2023
@TheLisaVL TheLisaVL changed the title Lingering references to the 'write plan' tab which no longer exists in mails Lingering references in mails to the 'write plan' tab which no longer exists Oct 19, 2023
@TheLisaVL
Copy link
Collaborator Author

Additional feedback on the mail templates: Every mail sent for plan create/invite/feedback should have a link to that plan.

@StCyr
Copy link
Collaborator

StCyr commented Apr 9, 2024

Hello @TheLisaVL,

References to the 'write plan' tab are gone since we no longer use it.

What do you mean by "we no longer use it"? Is it a dmponline.be specific configuration (in which case we should update it) or has it changed upstream (in which case they should update it)?

@StCyr
Copy link
Collaborator

StCyr commented Apr 9, 2024

problem reported upstream: DMPRoadmap/roadmap#3404

@StCyr StCyr added the roadmap Issue to be handled upstream label Apr 9, 2024
@TheLisaVL
Copy link
Collaborator Author

@StCyr Write plan is the phase name of a plan's first phase, however we changed it so now it displays the name of the phase instead of 'Write plan'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers roadmap Issue to be handled upstream
Projects
None yet
Development

No branches or pull requests

2 participants