From c9dfb64ab4a499abc64564f1bca6c5844a290aca Mon Sep 17 00:00:00 2001 From: Federico Stagni Date: Wed, 2 Oct 2024 14:10:17 +0200 Subject: [PATCH] sweep: #7810 fix: new pylint version fixes --- release.notes | 14 ++++++++++++++ src/DIRAC/Core/Tornado/Server/HandlerManager.py | 4 ++-- src/DIRAC/Core/Tornado/Server/TornadoServer.py | 2 +- .../Tornado/Server/private/BaseRequestHandler.py | 2 +- 4 files changed, 18 insertions(+), 4 deletions(-) diff --git a/release.notes b/release.notes index a7ed61ea2df..7b00f282ac9 100644 --- a/release.notes +++ b/release.notes @@ -6,6 +6,20 @@ FIX: (#7649) added log headers to InputDataResolution modules CHANGE: (#7629) add jobGroup to job parameters FIX: (#7584) ServerUtils: prevent getPilotAgentsDB from returning None FIX: (#7576) Fix potential circular import in WorkflowReader. Mostly seen in the creation of the documentation. +FIX: (#7787) added a 30s gfal2 timeout for downloading the SRR + +*TransformationSystem + +FIX: (#7741) RequestTaskAgent only considers requests in final states, and consider files in intermediate state as problematic (https://github.com/DIRACGrid/DIRAC/issues/7116) +NEW: (#7741) RequestTaskAgent uses getBulkRequestStatus instead of getRequestStatus +RMS: (#7741) +NEW: (#7741) implement getRequestStatus + +[v8.0.52] + +*ResourceStatusSystem + +FIX: (#7800) use always a from address (from Operations ResourceStatus/Config/FromAddress ) when sending email notifications, to avoid "spoofing" domains restrictions *WorkloadManagement diff --git a/src/DIRAC/Core/Tornado/Server/HandlerManager.py b/src/DIRAC/Core/Tornado/Server/HandlerManager.py index c087c4d0c18..9c48fb2f6dd 100644 --- a/src/DIRAC/Core/Tornado/Server/HandlerManager.py +++ b/src/DIRAC/Core/Tornado/Server/HandlerManager.py @@ -2,7 +2,7 @@ This module contains the necessary tools to discover and load the handlers for serving HTTPS """ -from DIRAC import gConfig, gLogger, S_ERROR, S_OK +from DIRAC import S_ERROR, S_OK, gConfig, gLogger from DIRAC.ConfigurationSystem.Client import PathFinder from DIRAC.Core.Base.private.ModuleLoader import ModuleLoader @@ -121,7 +121,7 @@ def __load(self, instances, componentType, pathFinder): # see DIRAC.Core.Tornado.Server.private.BaseRequestHandler for more details # this method should return a list of routes associated with the handler, it is a regular expressions # see https://www.tornadoweb.org/en/stable/routing.html#tornado.routing.URLSpec, ``pattern`` argument. - urls = handler._BaseRequestHandler__pre_initialize() + urls = handler._BaseRequestHandler__pre_initialize() # pylint: disable=no-member # First of all check if we can find route if not urls: diff --git a/src/DIRAC/Core/Tornado/Server/TornadoServer.py b/src/DIRAC/Core/Tornado/Server/TornadoServer.py index ccc0ea38f54..509974f92a2 100644 --- a/src/DIRAC/Core/Tornado/Server/TornadoServer.py +++ b/src/DIRAC/Core/Tornado/Server/TornadoServer.py @@ -12,7 +12,7 @@ import tornado.iostream -tornado.iostream.SSLIOStream.configure( +tornado.iostream.SSLIOStream.configure( # pylint: disable=no-member "tornado_m2crypto.m2iostream.M2IOStream" ) # pylint: disable=wrong-import-position diff --git a/src/DIRAC/Core/Tornado/Server/private/BaseRequestHandler.py b/src/DIRAC/Core/Tornado/Server/private/BaseRequestHandler.py index ddb57ae43e7..bb57e93f2df 100644 --- a/src/DIRAC/Core/Tornado/Server/private/BaseRequestHandler.py +++ b/src/DIRAC/Core/Tornado/Server/private/BaseRequestHandler.py @@ -952,7 +952,7 @@ async def __execute(self, *args, **kwargs): # pylint: disable=arguments-differ # you need to define the finish_ method. # This method will be started after _executeMethod is completed. elif callable(finishFunc := getattr(self, f"finish_{self.__methodName}", None)): - finishFunc() + finishFunc() # pylint: disable=not-callable # In case nothing is returned elif self.__result is None: