Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-please node-workspaces plugin does not follow the pre-release versioning strategy #216

Open
aldbr opened this issue Aug 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aldbr
Copy link
Collaborator

aldbr commented Aug 28, 2024

Bug has been reported here (a fix seems to be ready): googleapis/release-please#2248

In our context, when there is an update, we have:

  • diracx-web-components pre-release version bumped correctly (e.g. 0.1.0-a1 -> 0.1.0-a2)
  • diracx-web and extensions versions bumped incorrectly (e.g. 0.1.0-a1 -> 0.1.1-a1 instead of 0.1.0-a2)

See #215

@aldbr aldbr added the bug Something isn't working label Aug 28, 2024
@aldbr
Copy link
Collaborator Author

aldbr commented Nov 14, 2024

Update:

  • It works only if files from every sub-packages have been modified.
  • The bug was addressed rather quickly in the release-please repo...
  • ... But the release-please-action has not been updated properly since then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant