Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSIP114 conflicts with its examples #642

Closed
koit opened this issue Aug 11, 2020 · 4 comments
Closed

CSIP114 conflicts with its examples #642

koit opened this issue Aug 11, 2020 · 4 comments
Assignees
Labels
bug This issue describes a bug that needs to be investigated and handled

Comments

@koit
Copy link
Contributor

koit commented Aug 11, 2020

CSIP114 requires the presence of one or more mets/fileSec/fileGrp/@USE attributes with the value "Representations," i.e.:

USE="Representations"

However, the examples use more detailed values, e.g.:

USE="Representations/submission/data"
USE="Representations/preingest"
USE="Representations/submission"
USE="Representations/ingest"

Either the requirement text or the examples need to be changed.

@koit koit added the bug This issue describes a bug that needs to be investigated and handled label Aug 11, 2020
@karinbredenberg
Copy link
Contributor

Looks like there are text gone missing. The use starts with representations and the folder of what it is is given. But we cant put the rest of the value in the requirement just the start. Textual update will come in the next version.

@hsilva-keep
Copy link
Contributor

hsilva-keep commented Mar 17, 2021

@karinbredenberg All structMap representation LABEL related requirements have the same problem (CSIP101-CSIP104 and CSIP119).

So, the ideia is to assume that in both cases the logic is the same: the value starts with "Representations" and the whole value should be the path to the representation or representation data (like CSIP64 mentions)? Because if so, that logic colides with CSIPSTR13, which states that the folder name is "representation" (vs. "Representation").

(just for future reference, this is related to a previous issue I've raised, #555)

@karinbredenberg
Copy link
Contributor

CSIP101-104 and CSIP119 are relating to the package where no representations are present. In that case all file groups for the content being delivered the data is placed in one div in the structMap.

CSIP114 and CSIP107 have gotten a clarification for the use of the folder path following the value "Representations".

@karinbredenberg
Copy link
Contributor

Closed with PR #683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a bug that needs to be investigated and handled
Projects
None yet
Development

No branches or pull requests

4 participants