FHB-969 acceptance tests KV #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
StuwiiDev
commented
Nov 21, 2024
•
StuwiiDev
commented
- Add keyvault configurations to API acceptance tests
- Add Readmes to acceptance projects to explain using keyvault
added 6 commits
November 21, 2024 10:39
Added user secrets and appsettings for KV
Update the method to accept IConfigurationBuilder so that any form of builder can use it.
Add keyVault configuration to acceptance tests
StuwiiDev
requested review from
stevesatdfe,
a team and
AaronJY
and removed request for
a team
stevesatdfe
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Might be worth sticking a readme in each of the acceptance test projects to help people as they might not know if they need to configure:
"AppConfiguration": {
"KeyVaultIdentifier": "",
"KeyVaultPrefix": ""
}
Could add something like...
Test Setup
Use secrets to configure the variables but you can ignore:
"AppConfiguration": {
"KeyVaultIdentifier": "",
"KeyVaultPrefix": ""
}
'''
if you are running these locally as they are used by the pipeline to configure the tests.
...api/acceptance-tests/FamilyHubs.Referral.Api.AcceptanceTests/Configuration/ConfigAccessor.cs
Show resolved
Hide resolved
stevesatdfe
previously approved these changes
Nov 21, 2024
Top-Cat
reviewed
Nov 21, 2024
src/shared/shared-kernel/src/fh-shared-kernel.shared-kernel/Extensions/StartupExtensions.cs
Outdated
Show resolved
Hide resolved
Also removed the unnecessary extra method.
Top-Cat
approved these changes
Nov 22, 2024
Zac-Digital
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.