Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

128 read all object and rank level fields and write them out #129

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

128 read all object and rank level fields and write them out #129

wants to merge 9 commits into from

Conversation

lifflander
Copy link
Contributor

@lifflander lifflander commented Dec 6, 2024 •
edited
Loading

Fixes #128

This PR:

  • Write out all rank- and phase-level user-defined QOI fields to mesh files along with all object-level user-defined QOI fields
  • Allow the selection for generating PNGs of QOIs from user-defined for object or rank meshes
  • Appropriately type these fields dynamically based on the type detected in JSON

Linked to:

@lifflander lifflander linked an issue Dec 6, 2024 that may be closed by this pull request
Read all object- and rank-level fields and write them out #128
Open
This was referenced Dec 6, 2024
Merged
Merged
@lifflander
Copy link
Contributor Author

@pierrepebay @cwschilly How do I deal with this check that is failing due to the meshes changing?

cwschilly
cwschilly reviewed Dec 6, 2024
View reviewed changes
src/vt-tv/render/render.cc Outdated
Comment on lines 317 to 335
std::string rank_array_name = "Rank " + this->rank_qoi_;
std::string rank_array_name = this->rank_qoi_;
Copy link
Contributor

@cwschilly cwschilly Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lifflander This is the change that causes the failure.

To fix the pipelines, we just need to update the expected rank meshes in tests/expected/default and tests/expected/ccm_example to use the new array names.

@tlamonthezie Might have an idea of the best way to go about this.

@lifflander lifflander marked this pull request as ready for review December 10, 2024 19:48
@lifflander
Copy link
Contributor Author

@pierrepebay Do you know why macos-14 is failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwschilly cwschilly cwschilly left review comments

@pierrepebay pierrepebay Awaiting requested review from pierrepebay

@ppebay ppebay Awaiting requested review from ppebay

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read all object- and rank-level fields and write them out
3 participants
@lifflander @cwschilly @pierrepebay