Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#102: Add support for external fmt library #104

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

#102: Add support for external fmt library #104

wants to merge 4 commits into from

Conversation

cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Aug 7, 2024 •
edited
Loading

Fixes #102

@cwschilly cwschilly linked an issue Aug 7, 2024 that may be closed by this pull request
Add support for external fmt library #102
Open
@cwschilly cwschilly self-assigned this Aug 7, 2024
@cwschilly cwschilly marked this pull request as draft August 7, 2024 21:03
@cwschilly cwschilly force-pushed the 102-add-support-for-external-fmt-library branch 3 times, most recently from f30a65b to 5bbc238 Compare August 8, 2024 15:22
@cwschilly cwschilly force-pushed the 102-add-support-for-external-fmt-library branch from ec5a3c0 to f28f403 Compare August 26, 2024 15:46
@cwschilly
Copy link
Contributor Author

cwschilly commented Sep 3, 2024 •
edited
Loading

@pierrepebay @lifflander @nlslatt

This issue was originally motivated by vt PR 2294, but we ended up opting for a different approach (meaning that this PR is no longer necessary for vt-tv's integration into vt). Do we still want to add this functionality?

If so, I'll also need to add in a new CI pipeline to build and test with an external fmt

@cwschilly cwschilly force-pushed the 102-add-support-for-external-fmt-library branch from 77eea5d to 697c675 Compare September 4, 2024 13:59
@tlamonthezie tlamonthezie added the Low priority To be addressed after high priority label Sep 30, 2024
@ppebay
Copy link
Contributor

ppebay commented Oct 17, 2024

@pierrepebay @lifflander @nlslatt

This issue was originally motivated by vt PR 2294, but we ended up opting for a different approach (meaning that this PR is no longer necessary for vt-tv's integration into vt). Do we still want to add this functionality?

If so, I'll also need to add in a new CI pipeline to build and test with an external fmt

@lifflander @nlslatt @pierrepebay reiterating @cwschilly 's question above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cwschilly cwschilly

Labels
Low priority To be addressed after high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for external fmt library
3 participants
@cwschilly @ppebay @tlamonthezie