Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1: Implement new benchmark #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

#1: Implement new benchmark #2

wants to merge 13 commits into from
+386 −0

Conversation

lifflander
Copy link
Contributor

@lifflander lifflander commented Dec 18, 2024 •
edited by cwschilly
Loading

Fixes #1

I'm thinking about adding MPI_Get_processor_name in this or we could do it in a script instead.

@lifflander lifflander linked an issue Dec 18, 2024 that may be closed by this pull request
Implement new benchmark #1
Open
@lifflander
Copy link
Contributor Author

lifflander commented Dec 18, 2024 •
edited
Loading

This is the output it will produce on 8 ranks and 20 iterations that is meant to be read in by a script:

gather: 0: 3.26723: breakdown: 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272 0.154272
gather: 1: 3.21715: breakdown: 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019 0.149019
gather: 2: 3.24052: breakdown: 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853 0.151853
gather: 3: 3.28802: breakdown: 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015 0.149015
gather: 4: 3.27613: breakdown: 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472 0.147472
gather: 5: 3.27223: breakdown: 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965 0.152965
gather: 6: 3.29078: breakdown: 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535 0.147535
gather: 7: 3.25363: breakdown: 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264 0.151264

@cwschilly cwschilly changed the title #1: initial: implement slow node benchmark #1: Implement new benchmark Dec 18, 2024
nlslatt
nlslatt reviewed Dec 19, 2024
View reviewed changes
CMakeLists.txt
)

target_link_libraries(${SLOW_NODE_EXE} PUBLIC MPI::MPI_CXX)
target_link_libraries(${SLOW_NODE_EXE} PUBLIC Kokkos::kokkoskernels)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change this line to link against my installed Trilinos:

target_link_libraries(${SLOW_NODE_EXE} PUBLIC KokkosKernels::kokkoskernels)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need an option to switch between finding Trilinos and linking that way vs. directly using Kokkos kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt left review comments

@cwschilly cwschilly Awaiting requested review from cwschilly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new benchmark
3 participants
@lifflander @nlslatt @cwschilly