Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

344 implement user traits #345

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Matthew-Whitlock
Copy link
Contributor

@Matthew-Whitlock Matthew-Whitlock commented May 30, 2024

Closes #344

@Matthew-Whitlock Matthew-Whitlock linked an issue May 30, 2024 that may be closed by this pull request
@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch 5 times, most recently from 45d2aca to 28e3ef9 Compare June 6, 2024 17:37
@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch 2 times, most recently from 014e8dd to 02b04a2 Compare June 12, 2024 01:04
@nmm0 nmm0 requested review from lifflander and nmm0 June 18, 2024 17:18
@lifflander lifflander requested a review from cz4rs June 18, 2024 17:23
@nmm0
Copy link
Contributor

nmm0 commented Jun 18, 2024

@Matthew-Whitlock will this require some changes to VT?

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matthew-Whitlock PR tests with vt build is currently failing in the configuration stage and reports success incorrectly. #352 fixes both these issue, please rebase once it is merged.

Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About half reviewed

examples/checkpoint_example_user_traits.hpp Show resolved Hide resolved
src/checkpoint/checkpoint_api.h Outdated Show resolved Hide resolved
src/checkpoint/dispatch/dispatch.h Show resolved Hide resolved
src/checkpoint/dispatch/vrt/virtual_serialize.h Outdated Show resolved Hide resolved
src/checkpoint/serializers/reference.h Outdated Show resolved Hide resolved
src/checkpoint/serializers/reference.h Outdated Show resolved Hide resolved
src/checkpoint/serializers/reference.h Outdated Show resolved Hide resolved
src/checkpoint/serializers/reference.h Outdated Show resolved Hide resolved
src/checkpoint/serializers/reference.h Outdated Show resolved Hide resolved
@nmm0
Copy link
Contributor

nmm0 commented Oct 16, 2024

@Matthew-Whitlock Can you rebase and mark as ready for review?

@nmm0 nmm0 requested review from cz4rs and nmm0 October 16, 2024 16:42
Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, sorry it took so long I added a bunch comments

tests/unit/test_user_traits.cc Outdated Show resolved Hide resolved
src/checkpoint/serializers/serializer_ref.h Outdated Show resolved Hide resolved
src/checkpoint/traits/user_traits.h Outdated Show resolved Hide resolved
src/checkpoint/traits/user_traits.h Outdated Show resolved Hide resolved
tests/unit/test_user_traits.cc Show resolved Hide resolved
tests/unit/test_user_traits.cc Outdated Show resolved Hide resolved
tests/unit/test_user_traits.cc Outdated Show resolved Hide resolved
tests/unit/test_user_traits.cc Show resolved Hide resolved
tests/unit/test_user_traits.cc Show resolved Hide resolved
@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch 2 times, most recently from e721da2 to a8bd64c Compare November 11, 2024 14:24
@Matthew-Whitlock Matthew-Whitlock marked this pull request as ready for review November 11, 2024 14:28
@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch from a8bd64c to 3c73754 Compare November 11, 2024 15:23
@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch from 3c73754 to 6d96f2f Compare December 5, 2024 17:51
@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch from 6d96f2f to 43c12a0 Compare December 5, 2024 18:09
tests/unit/test_user_traits.cc Show resolved Hide resolved
src/checkpoint/traits/user_traits.h Outdated Show resolved Hide resolved
src/checkpoint/traits/user_traits.h Outdated Show resolved Hide resolved
src/checkpoint/traits/user_traits.h Show resolved Hide resolved
src/checkpoint/traits/user_traits.h Outdated Show resolved Hide resolved
Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :D

@nmm0
Copy link
Contributor

nmm0 commented Dec 12, 2024

@cz4rs can you re-review?

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only missing bit would be to integrate it with the documentation.

So far all existing examples were contained in .cc files (without headers), but it should be just fine to use two \snippets.

@Matthew-Whitlock Matthew-Whitlock force-pushed the 344-implement-user-traits branch from 4346e7d to 0d2e378 Compare December 17, 2024 16:46
@@ -0,0 +1,109 @@
#include "checkpoint/checkpoint.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header here

// *****************************************************************************
//@HEADER
*/
#include "checkpoint/checkpoint.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add as a documentation snippet

@@ -0,0 +1,109 @@
#include "checkpoint/checkpoint.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use scripts/check_guards.sh to add license and header guards here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement User Traits
5 participants