-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
344 implement user traits #345
base: develop
Are you sure you want to change the base?
Conversation
45d2aca
to
28e3ef9
Compare
014e8dd
to
02b04a2
Compare
@Matthew-Whitlock will this require some changes to VT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Matthew-Whitlock PR tests with vt
build is currently failing in the configuration stage and reports success incorrectly. #352 fixes both these issue, please rebase once it is merged.
02b04a2
to
274138b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About half reviewed
cf77dcb
to
772f17c
Compare
772f17c
to
5eecca8
Compare
5eecca8
to
783da5f
Compare
783da5f
to
f7ff36d
Compare
@Matthew-Whitlock Can you rebase and mark as ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, sorry it took so long I added a bunch comments
e721da2
to
a8bd64c
Compare
a8bd64c
to
3c73754
Compare
3c73754
to
6d96f2f
Compare
6d96f2f
to
43c12a0
Compare
ba76568
to
4346e7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :D
@cz4rs can you re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The only missing bit would be to integrate it with the documentation.
So far all existing examples were contained in .cc files (without headers), but it should be just fine to use two \snippet
s.
4346e7d
to
0d2e378
Compare
@@ -0,0 +1,109 @@ | |||
#include "checkpoint/checkpoint.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing header here
// ***************************************************************************** | ||
//@HEADER | ||
*/ | ||
#include "checkpoint/checkpoint.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add as a documentation snippet
@@ -0,0 +1,109 @@ | |||
#include "checkpoint/checkpoint.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use scripts/check_guards.sh
to add license and header guards here.
Closes #344