Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments to contiguousTyped #236

Open
PhilMiller opened this issue May 4, 2022 · 1 comment
Open

Fix arguments to contiguousTyped #236

PhilMiller opened this issue May 4, 2022 · 1 comment
Assignees
@PhilMiller

Comments

@PhilMiller
Copy link
Member

It used to be a static method, and so took a serializer argument. That wasn't dropped when it was made a non-static member.
@PhilMiller PhilMiller self-assigned this May 4, 2022
@PhilMiller
Copy link
Member Author

It looks like there are some dispatch quirks with how we want this to play with generalized traversal and the implementation of the base struct Serializer, which is the only one that implements contiguousTyped, with no contiguousBytes of its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilMiller PhilMiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilMiller