Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect remaining functions in rank_object_enumerator #401

Open
tlamonthezie opened this issue Jun 7, 2023 · 3 comments
Open

Inspect remaining functions in rank_object_enumerator #401

tlamonthezie opened this issue Jun 7, 2023 · 3 comments
Assignees

Comments

@tlamonthezie
Copy link
Contributor

tlamonthezie commented Jun 7, 2023

Check if we want to

  • keep functions used only by the rank_object_enumerator module
  • remove the rank_object_enumerator module ?
@tlamonthezie
Copy link
Contributor Author

tlamonthezie commented Jun 9, 2023

Check if we want to

  • keep functions used only by the rank_object_enumerator module
  • remove the rank_object_enumerator module ?

@ppebay with #386 we moved some usefule function compute_pairwise_reachable_arrangements to the lbsStatistics module.
Regarding the rank_object_enumerator script: if you want to keep the script we might close this issue ?

@ppebay
Copy link
Contributor

ppebay commented Sep 16, 2024

I agree that we can close the issue @tlamonthezie; please verify it's not breaking anything and close issue (as you are the issue creator)

@ppebay ppebay assigned tlamonthezie and unassigned ppebay Sep 16, 2024
@tlamonthezie
Copy link
Contributor Author

tlamonthezie commented Sep 16, 2024

@ppebay the rank_object_enumerator script has been removed by the following PR https://github.com/DARMA-tasking/LB-analysis-framework/pull/408/files
The functions that were called by the rank_object_enumerator script seem unused

Statistics::compute_all_reachable_arrangements
Statistics::recursively_compute_transitions

Should we remove it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants