Issue 14: Add initial FilesXml and Metadata classes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindareijnhoudt
commented
Aug 3, 2018
| val AVAILABLE: DcTermsElementType = Value | ||
| val BIBLIOGRAPHIC_CITATION: DcTermsElementType = Value("bibliographicCitation") | ||
| val CONFORMS_TO: DcTermsElementType = Value("conformsTo") | ||
| // val CONTRIBUTOR: DcTermsElementType = Value |
There was a problem hiding this comment.
these are already defined in the dc-realm.
jo-pol
reviewed
Aug 6, 2018
| val DEU: XmlLang = Value | ||
| } | ||
|
|
||
| object DcTermsElementType extends Enumeration { |
There was a problem hiding this comment.
This is not limited to FilesXml but also applies to DatasestXml so put it in a separate file. It is not even limited to V0 so put it in another package.
jo-pol
reviewed
Dec 11, 2018
| // val DATE: DcTermsElementType = Value | ||
| val DATE_ACCEPTED: DcTermsElementType = Value("dateAccepted") | ||
| val DATE_COPYRIGHTED: DcTermsElementType = Value("dateCopyrighted") | ||
| val DATE_SUBMITTED: DcTermsElementType = Value("dateSubmitted") |
There was a problem hiding this comment.
Not even considering the overall approach, this is a too big unstructured pile of types.
How to reuse (for example) dates by the deposit-api other enums in the same dm package of the api, relation types and whatever?
|
This has been open for more than a year now. We still need to decide how to implement this, but so far we haven't done anything with it. Closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14
When applied it will
Where should the reviewer @DANS-KNAW/easy start?