Add query to approver to get proposal ID from pre-propose ID #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the pre propose approval ID.
NoahSaso
changed the title
JakeHartnell
approved these changes
Nov 20, 2023
|
Small linting error... but otherwise looks good. |
|
Ah, not your linting error. Going to merge this, fixing the linting error in another PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another missing query to the
dao-pre-propose-approvercontract to allow retrieving the approver's proposal ID attached to a given pre-propose-approval pending or completed proposal. This addition means the contract now bidirectional querying to get the attached approval proposal from either side. This is necessary in order to locate and link to the corresponding proposal.