Use indexed map for proposal modules #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional query parameter 'include_disabled' that is false by default Removed ActiveProposalModule query Added a migrate path FromV2
ismellike
commented
Sep 11, 2023
| .range(deps.storage, None, None, cosmwasm_std::Order::Ascending) | ||
| .map(|kv| Ok(kv?.1)) | ||
| .collect::<StdResult<Vec<ProposalModule>>>()?; | ||
| let proposal_modules = query_proposal_modules(deps, None, None, None)?; |
There was a problem hiding this comment.
Only active proposal modules are listed here now
Errors weren't visible, because test-tube doesn't run for the windows plebs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional query parameter 'include_disabled' on ProposalModule that is false by default
Removed ActiveProposalModule query
Added a migrate path FromV2