Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or split MagicOnion.Shared #652

Closed
mayuki opened this issue Jun 1, 2023 · 2 comments
Closed

Remove or split MagicOnion.Shared #652

mayuki opened this issue Jun 1, 2023 · 2 comments
Labels
area-Project stale stale not updated issue & pr

Comments

@mayuki
Copy link
Member

mayuki commented Jun 1, 2023

Relates to #647

MagicOnion.Shared assembly/package exists independently, but not for Unity.
This causes problems when the generated client is compiled as a DLL and brought into Unity.

We have two options:

  • Make all part of Server or Client by source sharing
  • Separate MagicOnion.Shared from MagicOnion.Client in the Unity package.
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale stale not updated issue & pr label Nov 29, 2023
@mayuki
Copy link
Member Author

mayuki commented Nov 30, 2023

Fixed #707

@mayuki mayuki closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Project stale stale not updated issue & pr
Projects
None yet
Development

No branches or pull requests

1 participant