We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas Optimization / Informational
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/d1c5501aa79320ca0aeaa73f47f0dbc88c7b77e2/src/DSCEngine.sol#L331C10-L331C10
There is a constant variable called PRECISION = 1e18. So that we can use PRECISION instead of 1e18 everywhere in the codebase.
return (collateralAdjustedForThreshold * 1e18) / totalDscMinted; In above code => PRECISION = 1e18
Gas Optimization
Manual Review
The text was updated successfully, but these errors were encountered:
No branches or pull requests
PRECISION
Severity
Gas Optimization / Informational
Relevant GitHub Links
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/d1c5501aa79320ca0aeaa73f47f0dbc88c7b77e2/src/DSCEngine.sol#L331C10-L331C10
Summary
There is a constant variable called PRECISION = 1e18. So that we can use PRECISION instead of 1e18 everywhere in the codebase.
Vulnerability Details
return (collateralAdjustedForThreshold * 1e18) / totalDscMinted;
In above code => PRECISION = 1e18
Impact
Gas Optimization
Tools Used
Manual Review
Recommendations
The text was updated successfully, but these errors were encountered: