Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly different lighting used in 1.15 #10

Open
IronPiston opened this issue May 14, 2020 · 3 comments
Open

Slightly different lighting used in 1.15 #10

IronPiston opened this issue May 14, 2020 · 3 comments

Comments

@IronPiston
Copy link

Issue type:

  • 🐛 Bug

Short description:

Incorrect lighting is used on the 1.15 version. The GUI lighting was changed from 1.14, but the exported icons don't reflect this

Steps to reproduce the problem:

  1. Use the 1.15 version
  2. Export any block

Expected behaviour:

The exported icon should have identical lighting to the in-game icons


Versions:

  • This mod: 1.15.2-1.6.2
  • Minecraft: 1.15.2
  • Forge: 31.1.77
@rubensworks
Copy link
Member

What icons are you having issues with? Because they all work fine on my end.

@IronPiston
Copy link
Author

This is stone from IconExporter
minecraft__stone

And this is a cropped screenshot of stone in the player inventory
Sprite-0001

If I use a color tester on the right face, they don't seem to match.

@rubensworks
Copy link
Member

There seems to be a slight difference indeed if you look closely.
Not sure if a fix for this will be easy, since I basically had to rewrite the whole lighting system to account for scaling.

Putting this issue on a lower priority.

PRs on this are welcome.

@rubensworks rubensworks changed the title Incorrect lighting used in 1.15 Slightly different lighting used in 1.15 May 15, 2020
@rubensworks rubensworks removed the bug label May 15, 2020
@rubensworks rubensworks moved this to Options in Features Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Options
Development

No branches or pull requests

2 participants