Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf metadata.tools not updated in v1.5 #276

Open
coderpatros opened this issue Aug 2, 2023 · 4 comments
Open

Protobuf metadata.tools not updated in v1.5 #276

coderpatros opened this issue Aug 2, 2023 · 4 comments

Comments

@coderpatros
Copy link
Member

No description provided.

@coderpatros coderpatros added this to the 1.6 milestone Aug 2, 2023
@coderpatros coderpatros self-assigned this Aug 2, 2023
@jkowalleck jkowalleck added the CDX 1.5 related to release v1.5 label Aug 2, 2023
@jkowalleck jkowalleck changed the title Protobuf metadata tools not updated in v1.5 Protobuf metadata.tools not updated in v1.5 Dec 4, 2023
@jkowalleck
Copy link
Member

i will take this over

@jkowalleck
Copy link
Member

will have this issue fixed, as soon as
#385
is done

@jkowalleck
Copy link
Member

jkowalleck commented Mar 18, 2024

v1.4:

repeated Tool tools = 2;

v1.5:

optional Tool tools = 2;

Once, tools was a repeated list of Tool ...
Now is just one element at max? wtf ... this was an odd decision ...
Because now I can express one tool at max. not all of them ...
well, this was a breaking change .... again ...

But at least the Tool got a list of compoentns and services to represent other "tools"

// A list of software and hardware components used as tools
repeated Component components = 6;
// A list of services used as tools. This may include microservices, function-as-a-service, and other types of network or intra-process services.
repeated Service services = 7;

To me this issue seams to be solved, even though the solution was just odd.

@jkowalleck
Copy link
Member

@coderpatros could you review my conclusion, and decide whether the issue is solved?

@jkowalleck jkowalleck removed this from the 1.6 milestone Mar 18, 2024
@jkowalleck jkowalleck removed their assignment Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants