Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run tox w/o sdist #819

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore: run tox w/o sdist #819

merged 1 commit into from
Oct 22, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Oct 22, 2024

our sdist config ships tests and docs.

when you have a lot of venvs laying around in the tests or docs flder, then poetry build -f sdist crashes ... a known bug of poetry ...

per default, tox installs in sdist mode ....
this causes issues locally, ... which is annoying.

here is a workaround: dont build sdist, build wheel only.

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck requested a review from a team as a code owner October 22, 2024 17:09
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0feede2) 1071 1036 96.73%
Head commit (f164670) 1071 (+0) 1036 (+0) 96.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#819) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck merged commit f64ccaf into main Oct 22, 2024
34 checks passed
@jkowalleck jkowalleck deleted the chore/tox-no-sdist branch October 22, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant