Feat: omit development dependencies from SBOM results #534
Conversation
…anch Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
There was a problem hiding this comment.
Thanks for your work, @tngraf.
There are critical bugs that need to be fixed. There are implementation details that need to be addressed.
These were marked with ❌ and ❗ and MUST be fixed.
I added other annotations which should be followed, or can be discussed.
| @@ -235,6 +235,10 @@ def get_arg_parser(*, prog: Optional[str] = None) -> argparse.ArgumentParser: | |||
| '-pb', '--purl-bom-ref', action='store_true', dest='use_purl_bom_ref', | |||
| help="Use a component's PURL for the bom-ref value, instead of a random UUID" | |||
| ) | |||
| arg_parser.add_argument( | |||
| "-omit", "--omit", dest="omit", action="append", | |||
| help="Omit specified items when using Poetry or PipEnv (currently supported is dev)", | |||
There was a problem hiding this comment.
❗ help text does not declare allowed values properly.
Let's mark this as an open topic and concentrate on the implementations first.
FYI: CLI and argparse might change to another implementation soon.
don't waste time now, we can discuss this at the feature finalization phase.
There was a problem hiding this comment.
My assumption was that currently supported is dev is enough to get started.
There was a problem hiding this comment.
lets leave this open.
if we go with Click8 then the help text generator will take over here.
There was a problem hiding this comment.
we will fix this during the CLI/click8/subcomamnd rework
Signed-off-by: Thomas Graf <[email protected]>
|
I do not like the implementation that the parsers do the filtering. read also: #474 (comment) |
Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
There was a problem hiding this comment.
Couple of minor changes / updates mostly same as per @jkowalleck
|
Agree @jkowalleck - but let's not complicate this addition with that bad brush. We can handle / refactor later... |
|
re: #534 (comment) agree. |
jkowalleck
changed the title
Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
Implements #474 in 4.x.x branch as discussed with @jkowalleck and @madpah